Transform optional attributes into empty collections for cleaner, safer, and polymorphic code, banishing the billion-dollar mistake Transform optional attributes into empty collections for cleaner, safer, and polymorphic code, banishing the billion-dollar mistake TL;DR: Replace nullable optional attributes with empty collections to eliminate null checks and leverage polymorphism. TL;DR: Replace nullable optional attributes with empty collections to eliminate null checks and leverage polymorphism. Problems Addressed 😔 Nulls reference exceptions
Excessive conditional logic and IFs
Fragile error handling
Optional Attributes
Complex validation code
Polymorphism Violation Nulls reference exceptions Nulls Excessive conditional logic and IFs IFs Fragile error handling Optional Attributes Optional Attributes Complex validation code Polymorphism Violation Polymorphism Violation Related Code Smells 💨 https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xxxix?embedable=true https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xxxix?embedable=true https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xxx?embedable=true https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xxx?embedable=true https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-iv-7sc3w8n?embedable=true https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-iv-7sc3w8n?embedable=true https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-iii-t7h3zkv?embedable=true https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-iii-t7h3zkv?embedable=true https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-ix-7rr33ol?embedable=true https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-ix-7rr33ol?embedable=true Steps 👣 Identify nullable optional attributes that could be collections
Replace single nullable objects with empty collections
Remove all null checks related to these optional attributes
Update methods to work with collections instead of single objects Identify nullable optional attributes that could be collections Replace single nullable objects with empty collections Remove all null checks related to these optional attributes Update methods to work with collections instead of single objects Sample Code 💻 Before  🚨 public class ShoppingCart {
    private List<Item> items = new ArrayList<>();
    private Coupon coupon = null;
    
    public void addItem(Item item) {
        this.items.add(item);
    }
    
    public void redeemCoupon(Coupon coupon) {
        this.coupon = coupon;
    }
    
    public double total() {
        double total = 0;
        
        for (Item item : this.items) {
            total += item.getPrice();
        }
        
        // This a polluted IF and null check
        if (this.coupon != null) {
            total -= this.coupon.getDiscount();
        }
        
        return total;
    }
    
    public boolean hasUnsavedChanges() {
        // Explicit null check
        return !this.items.isEmpty() || this.coupon != null;
    }
    
    public boolean hasCoupon() {        
        return this.coupon != null;
    }
} public class ShoppingCart {
    private List<Item> items = new ArrayList<>();
    private Coupon coupon = null;
    
    public void addItem(Item item) {
        this.items.add(item);
    }
    
    public void redeemCoupon(Coupon coupon) {
        this.coupon = coupon;
    }
    
    public double total() {
        double total = 0;
        
        for (Item item : this.items) {
            total += item.getPrice();
        }
        
        // This a polluted IF and null check
        if (this.coupon != null) {
            total -= this.coupon.getDiscount();
        }
        
        return total;
    }
    
    public boolean hasUnsavedChanges() {
        // Explicit null check
        return !this.items.isEmpty() || this.coupon != null;
    }
    
    public boolean hasCoupon() {        
        return this.coupon != null;
    }
} public class ShoppingCart {
    private final List<Item> items = new ArrayList<>();
  
    // This version uses Optionals
    // Not all programming languages support this feature
    private Optional<Coupon> coupon = Optional.empty();

    public void addItem(Item item) {
        items.add(item);
    }

    public void redeemCoupon(Coupon coupon) {
        // You need to understand how optionals work
        this.coupon = Optional.ofNullable(coupon);
    }
    
    public boolean hasUnsavedChanges() {
        return !items.isEmpty() || !coupon.isPresent();
    }

    public boolean hasCoupon() {
        return coupon.isPresent();
    }
} public class ShoppingCart {
    private final List<Item> items = new ArrayList<>();
  
    // This version uses Optionals
    // Not all programming languages support this feature
    private Optional<Coupon> coupon = Optional.empty();

    public void addItem(Item item) {
        items.add(item);
    }

    public void redeemCoupon(Coupon coupon) {
        // You need to understand how optionals work
        this.coupon = Optional.ofNullable(coupon);
    }
    
    public boolean hasUnsavedChanges() {
        return !items.isEmpty() || !coupon.isPresent();
    }

    public boolean hasCoupon() {
        return coupon.isPresent();
    }
} After 👉 public class ShoppingCart {
  private List<Item> items = new ArrayList<>();
    
  // 1. Identify nullable optional attributes
  // that could be collections
  // 2. Replace single nullable objects with empty collections
  private List<Coupon> coupons = new ArrayList<>();
    
  public void addItem(Item item) {
      this.items.add(item);
  }
    
  // Step 4: Work with collection
  // instead of single nullable object
  public void redeemCoupon(Coupon coupon) {
      this.coupons.add(coupon);
  }
    
  // Step 4: Simplified logic without null checks
  public double total() {
    double total = 0;
      
    for (Item item : this.items) {
        total += item.getPrice();
    }
      
    // 3. Remove all null checks 
    // related to these optional attributes        
    for (Coupon coupon : this.coupons) {
        total -= coupon.getDiscount();
    }
      
    return total;
  }
    
  // Consistent behavior with empty collections
  public boolean hasUnsavedChanges() {
    // 4. Update methods to work with collections
    // instead of single objects 
    return !this.items.isEmpty() || !this.coupons.isEmpty();
  }
    
  // 3. Remove all null checks 
  // related to these optional attributes
  // Collection-based check instead of null check
  public boolean hasCoupon() {
    return !this.coupons.isEmpty();
  }
} public class ShoppingCart {
  private List<Item> items = new ArrayList<>();
    
  // 1. Identify nullable optional attributes
  // that could be collections
  // 2. Replace single nullable objects with empty collections
  private List<Coupon> coupons = new ArrayList<>();
    
  public void addItem(Item item) {
      this.items.add(item);
  }
    
  // Step 4: Work with collection
  // instead of single nullable object
  public void redeemCoupon(Coupon coupon) {
      this.coupons.add(coupon);
  }
    
  // Step 4: Simplified logic without null checks
  public double total() {
    double total = 0;
      
    for (Item item : this.items) {
        total += item.getPrice();
    }
      
    // 3. Remove all null checks 
    // related to these optional attributes        
    for (Coupon coupon : this.coupons) {
        total -= coupon.getDiscount();
    }
      
    return total;
  }
    
  // Consistent behavior with empty collections
  public boolean hasUnsavedChanges() {
    // 4. Update methods to work with collections
    // instead of single objects 
    return !this.items.isEmpty() || !this.coupons.isEmpty();
  }
    
  // 3. Remove all null checks 
  // related to these optional attributes
  // Collection-based check instead of null check
  public boolean hasCoupon() {
    return !this.coupons.isEmpty();
  }
} Type 📝 [x]Semi-Automatic [x]Semi-Automatic [x] Safety 🛡️ This refactoring is generally safe when you control all access points to the collection attributes. You need to ensure that no external code expects null values and deal with the inside APIs. The refactoring maintains the same external behavior while simplifying internal logic. You should verify that all constructors and factory methods initialize collections properly. Why is the Code Better? ✨ The refactored code eliminates null pointer exceptions and reduces conditional complexity. null pointer exceptions Empty collections and non-empty collections behave polymorphically, allowing you to treat them uniformly. The code becomes more predictable since collections always exist (at least empty) and respond to the same operations. Method implementations become shorter and more focused on business logic rather than null handling. The approach aligns with the principle of making illegal states unrepresentable in your domain model, leading to more robust and maintainable code. Empty collections and non-empty collections are polymorphic. polymorphic How Does it Improve the Bijection? 🗺️ In the real world, containers exist even when empty. By representing optional collections as empty collections rather than null, you create a more accurate model of reality. Null does not exist in the real world, and it always breaks the  bijection. bijection This maintains the one-to-one correspondence between real-world concepts and your computational model, creating a good MAPPER. MAPPER When you return a collection instead of nulls, you also reduce the coupling. coupling Limitations ⚠️ This refactoring may not be suitable when null has a semantic meaning different from "empty". Some legacy APIs might expect null values, requiring adaptation layers. You need to ensure all code paths initialize collections consistently to avoid mixed null and empty states. Refactor With AI 🤖 Suggested Prompt: 1. Identify nullable optional attributes that could be collections 2. Replace single nullable objects with empty collections 3. Remove all null checks related to these optional attributes 4. Update methods to work with collections instead of single objects 5. Test that empty and non-empty collections behave consistently Suggested Prompt: 1. Identify nullable optional attributes that could be collections 2. Replace single nullable objects with empty collections 3. Remove all null checks related to these optional attributes 4. Update methods to work with collections instead of single objects 5. Test that empty and non-empty collections behave consistently Without Proper Instructions

With Specific Instructions



ChatGPT

ChatGPT



Claude

Claude



Perplexity

Perplexity



Copilot

Copilot



Gemini

Gemini



DeepSeek

DeepSeek



Meta AI

Meta AI



Grok

Grok



Qwen

Qwen Without Proper Instructions

With Specific Instructions



ChatGPT

ChatGPT



Claude

Claude



Perplexity

Perplexity



Copilot

Copilot



Gemini

Gemini



DeepSeek

DeepSeek



Meta AI

Meta AI



Grok

Grok



Qwen

Qwen Without Proper Instructions

With Specific Instructions Without Proper Instructions Without Proper Instructions With Specific Instructions With Specific Instructions ChatGPT

ChatGPT ChatGPT ChatGPT ChatGPT ChatGPT ChatGPT ChatGPT Claude

Claude Claude Claude Claude Claude Claude Claude Perplexity

Perplexity Perplexity Perplexity Perplexity Perplexity Perplexity Perplexity Copilot

Copilot Copilot Copilot Copilot Copilot Copilot Copilot Gemini

Gemini Gemini Gemini Gemini Gemini Gemini Gemini DeepSeek

DeepSeek DeepSeek DeepSeek DeepSeek DeepSeek DeepSeek DeepSeek Meta AI

Meta AI Meta AI Meta AI Meta AI Meta AI Meta AI Meta AI Grok

Grok Grok Grok Grok Grok Grok Grok Qwen

Qwen Qwen Qwen Qwen Qwen Qwen Qwen Tags 🏷️ Null Null Level 🔋 [x]Intermediate [x]Intermediate [x] Related Refactorings 🔄 https://hackernoon.com/code-refactoring-tips-no-015-remove-null?embedable=true https://hackernoon.com/code-refactoring-tips-no-015-remove-null?embedable=true https://hackernoon.com/refactoring-014-how-to-remove-if?embedable=true https://hackernoon.com/refactoring-014-how-to-remove-if?embedable=true See also 📚 https://hackernoon.com/null-the-billion-dollar-mistake-8t5z32d6?embedable=true https://hackernoon.com/null-the-billion-dollar-mistake-8t5z32d6?embedable=true https://hackernoon.com/how-to-get-rid-of-annoying-ifs-forever-zuh3zlo?embedable=true https://hackernoon.com/how-to-get-rid-of-annoying-ifs-forever-zuh3zlo?embedable=true Credits 🙏 Image by Eak K. on Pixabay Eak K. Pixabay This article is part of the Refactoring Series. https://maximilianocontieri.com/how-to-improve-your-code-with-easy-refactorings?embedable=true https://maximilianocontieri.com/how-to-improve-your-code-with-easy-refactorings?embedable=true

Misusing HTTP Status Codes Wrecks Your API Monitoring and Client Logic

Don't Mix Data Access Concerns With Essential Business Behavior

Buy My Book

Refactoring 029 - How to Replace NULL With Collection

About Author

Comments

TOPICS

THIS ARTICLE WAS FEATURED IN

Related Stories

Untitled Story

10 Predictions About the Future of Finance

100 Pieces of Programming Advice from the Book Clean Code by Robert Martin

10 Ways to Prevent and Manage Technical Debt—Tips from Developers

10 Expert Tips for Improving Code Reviews: A Guide for Developers

10 Coding Hacks to Remember in 2023

10 Predictions About the Future of Finance

100 Pieces of Programming Advice from the Book Clean Code by Robert Martin

10 Ways to Prevent and Manage Technical Debt—Tips from Developers

10 Expert Tips for Improving Code Reviews: A Guide for Developers

10 Coding Hacks to Remember in 2023

Light-Mode

Classic

Newspaper

Dark-Mode

Neon Noir

Minty

HN StartUps