Sig det én gang og kun én gang  TL;DR: Undgå duplikerede e-mail-valideringer.  Problemer rettet    flere steder. Gentagen e-mail-valideringslogik  Risiko for inkonsistente valideringsregler.  Overtrædelse  af Bijektion   Primitiv besættelse   For tidlig optimering  Relateret kode lugte   https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-x-i7r34uj   https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xxv   https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xiv   https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xxxvi   Kode Smell 20 - For tidlig optimering  Trin  Identificer, hvor e-mailvalideringslogikken er duplikeret.  Opret en   for at indkapsle valideringsregler. Email Address  Refaktorer kode for at bruge   i stedet for rå strenge. Email Address  Eksempel kode  Før   public class Person { private String emailAddress; // Primitive Obsession public void setEmailAddress(String emailAddress) { // Duplicated code if (!emailAddress.matches( "^[\\w.%+-]+@[\\w.-]+\\.[a-zA-Z]{2,}$")) { throw new IllegalArgumentException( "Invalid email address format"); } this.emailAddress = emailAddress; } } public class JobApplication { private String applicantEmailAddress; public void setApplicantEmailAddress(String emailAddress) { // Duplicated code if (!emailAddress.matches( "^[\\w.%+-]+@[\\w.-]+\\.[a-zA-Z]{2,}$")) { throw new IllegalArgumentException( "Invalid email address format"); } this.applicantEmailAddress = emailAddress; } }  Efter   public class EmailAddress { // 2. Create an `EmailAddress` class to encapsulate validation rules. private final String value; public EmailAddress(String value) { // The rules are in a single place // And all objects are created valid if (!value.matches("^[\\w.%+-]+@[\\w.-]+\\.[a-zA-Z]{2,}$")) { throw new IllegalArgumentException( "Invalid email address format"); } this.value = value; } } public class Person { private final EmailAddress emailAddress; public Person(EmailAddress emailAddress) { // 1. Identify where email validation logic is duplicated. // 3. Refactor code to use the `Email Address` // class instead of raw strings. // No validation is required this.emailAddress = emailAddress; } } public class JobApplication { private EmailAddress applicantEmailAddress; public JobApplication(EmailAddress applicantEmailAddress) { this.applicantEmailAddress = applicantEmailAddress; } }  Type    Halvautomatisk [x]  Sikkerhed  Denne refactoring er sikker, hvis du erstatter alle forekomster af rå e-mail-strenge med klassen 'EmailAddress' og sikrer, at alle tests består.  Hvorfor er koden bedre?  Du gør e-mailvalidering konsistent på tværs af din ansøgning.  Da valideringsregler er centraliseret ét sted, bliver koden lettere at vedligeholde.  Du reducerer også risikoen for fejl forårsaget af inkonsekvent logik.  I den virkelige verden er     , der eksisterer og ikke er strenge. Email Addresses små objekter  Den refaktorerede kode er tættere på den virkelige   . MAPPER  Bemærk, at bijektionsnavne er vigtige. Det ville hjælpe at oprette en   , ikke en   , da e-mailen skal   til den faktiske besked. EmailAddress Email knyttes  Lad ikke   fortælle dig, at denne løsning har en præstationsstraf. Premature Optimizers  De laver aldrig egentlige benchmarks med data fra den virkelige verden.  Refaktor med AI  Uden ordentlige instruktioner  Med specifikke instruktioner   ChatGPT   ChatGPT   Claude   Claude   Forvirring   Forvirring   Copilot   Copilot   Tvillingerne   Tvillingerne  Tags  Indkapsling  Relaterede Refactorings   https://maximilianocontieri.com/refactoring-007-extract-class?embedable=true   https://maximilianocontieri.com/refactoring-012-reify-associative-arrays?embedable=true   https://hackernoon.com/improving-the-code-one-line-at-a-time?embedable=true  Kreditter  Billede af   på  Gerd Altmann Pixabay  Denne artikel er en del af Refactoring-serien.   Sådan forbedrer du din kode med nemme refactorings

Winner of Noonies 2020 for the award Hacker Noon Contributor of the Year - REFACTORING.

2020 - Hacker Noon Contributor of the Year in REFACTORING

2022 - HackerNoon Contributor of the Year - Clean Code

2022 - HackerNoon Contributor of the Year - Debugging

2022 - HackerNoon Contributor of the Year - Github

2022 - HackerNoon Contributor of the Year - Machine Learning

2022 - HackerNoon Contributor of the Year - Quality Assurance

2022 - HackerNoon Contributor of the Year - Refactoring

2022 - HackerNoon Contributor of the Year - Software Architecture

2022 - the Greatest Storyteller

Buy My Book

Share your ideas with me!

Read My Stories

Buy Me a Coffee

Software Engineer and Book Author

Denne lyd er produceret på historiens originalsprog!

For langt; At læse

Refactoring 019 - Sådan bekræftes e-mail-adresser

Refactoring 019 - Sådan bekræftes e-mail-adresser

About Author

KOMMENTARER

HÆNG TAGS

DENNE ARTIKEL BLEV PRÆsenterET I

Related Stories

Meet inDrive: The HackerNoon Company of the Week

Yale Media Relations for Entrepreneurs with Journalist Walter Thompson & HackerNoon CEO David Smooke

Meet IONOS: HackerNoon Company of the Week

Meet KuCoin Community Chain: HackerNoon Company of the Week

Meet inDrive: The HackerNoon Company of the Week

Yale Media Relations for Entrepreneurs with Journalist Walter Thompson & HackerNoon CEO David Smooke

Meet IONOS: HackerNoon Company of the Week

Meet KuCoin Community Chain: HackerNoon Company of the Week

Light-Mode

Classic

Newspaper

Dark-Mode

Neon Noir

Minty

HN StartUps