Turn hidden private logic into a real concept without using AI. Turn hidden private logic into a real concept without using AI. TL;DR: You can and should test private methods Problems Addressed 😔 Broken encapsulationHidden rulesWhite-box Testing DependenciesHard testingMixed concernsLow reuseCode Duplication in TestsMissing Small objects Broken encapsulation Hidden rules White-box Testing Dependencies Hard testing Mixed concerns Low reuse Code Duplication in Tests Missing Small objects Small objects Related Code Smells 💨 https://maximilianocontieri.com/code-smell-112-testing-private-methods https://maximilianocontieri.com/code-smell-112-testing-private-methods https://maximilianocontieri.com/code-smell-22-helpers https://maximilianocontieri.com/code-smell-22-helpers https://maximilianocontieri.com/code-smell-18-static-functions https://maximilianocontieri.com/code-smell-18-static-functions https://maximilianocontieri.com/code-smell-21-anonymous-functions-abusers https://maximilianocontieri.com/code-smell-21-anonymous-functions-abusers https://www.linkedin.com/pulse/code-smell-177-missing-small-objects-maximiliano-contieri https://www.linkedin.com/pulse/code-smell-177-missing-small-objects-maximiliano-contieri Context 💬 I was pair programming with an AI Agent and asked it to create some unit tests for a private method I was about to modify, TDD Way. TDD Way The proposed solution used metaprogramming, which is a mistake almost every time. metaprogramming You need to be in control and not trust AI blindly. trust AI blindly Steps 👣 Identify a private method that needs testing.Name the real responsibility behind that logic.Extract the logic into a new class.Pass the needing objects explicitly through method arguments.Replace the private call with the new object. Identify a private method that needs testing. Name the real responsibility behind that logic. Extract the logic into a new class. Pass the needing objects explicitly through method arguments. Replace the private call with the new object. This is a special case for the Extract Method refactoring Extract Method refactoring Sample Code 💻 Before 🚨 <?php

final class McpMessageParser {
    private $raw;

    public function parse() {
        return $this->stripStrangeCharacters($this->raw);
    }

    // This is the private method me need to test 
    // For several different scenarios
    // Simplified here
    private function stripStrangeCharacters($input) {
        return preg_replace('/[^a-zA-Z0-9_:-]/', '', $input);
    }
} <?php

final class McpMessageParser {
    private $raw;

    public function parse() {
        return $this->stripStrangeCharacters($this->raw);
    }

    // This is the private method me need to test 
    // For several different scenarios
    // Simplified here
    private function stripStrangeCharacters($input) {
        return preg_replace('/[^a-zA-Z0-9_:-]/', '', $input);
    }
} Intermediate solution by AI This is a wrong approach using Metaprogramming. Metaprogramming <?php

use PHPUnit\Framework\TestCase;

final class McpMessageParserTest extends TestCase {
    private function invokePrivateMethod(
        $object, 
        $methodName, 
        array $parameters = []
    ) {
        $reflection = new ReflectionClass(get_class($object));
        // This is metaprogramming.
        // That generates fragile and hidden dependencies
        // You need to avoid it
        $method = $reflection->getMethod($methodName);
        $method->setAccessible(true);
        return $method->invokeArgs($object, $parameters);
    }

    public function testStripStrangeCharactersRemovesSpecialChars() {
        $parser = new McpMessageParser();
        $result = $this->invokePrivateMethod(
            $parser, 
            'stripStrangeCharacters', 
            ['hello@world#test']
        );
        $this->assertEquals('helloworldtest', $result);
    }

    public function testStripStrangeCharactersKeepsValidCharacters() {
        $parser = new McpMessageParser(); <?php

use PHPUnit\Framework\TestCase;

final class McpMessageParserTest extends TestCase {
    private function invokePrivateMethod(
        $object, 
        $methodName, 
        array $parameters = []
    ) {
        $reflection = new ReflectionClass(get_class($object));
        // This is metaprogramming.
        // That generates fragile and hidden dependencies
        // You need to avoid it
        $method = $reflection->getMethod($methodName);
        $method->setAccessible(true);
        return $method->invokeArgs($object, $parameters);
    }

    public function testStripStrangeCharactersRemovesSpecialChars() {
        $parser = new McpMessageParser();
        $result = $this->invokePrivateMethod(
            $parser, 
            'stripStrangeCharacters', 
            ['hello@world#test']
        );
        $this->assertEquals('helloworldtest', $result);
    }

    public function testStripStrangeCharactersKeepsValidCharacters() {
        $parser = new McpMessageParser(); After 👉 <?php

final class McpMessageParser {
    private $raw;

    public function parse() {
        // Step 5: Replace the private method call 
        // with the new object
        $stripper = new CharacterStripper($this->raw);
        return $stripper->strip();
    }
}

// CharacterStripper.php
// Step 2: Create a new class (Method Object)
final class CharacterStripper {
    private $input;

    // Step 4: Pass all necessary data as constructor 
    // parameters
    public function __construct($input) {
        $this->input = $input;
    }

    // Step 3: Move the private method logic 
    // to the new class
    public function strip() {
        return preg_replace(
            '/[^a-zA-Z0-9_:-]/', 
            '', 
            $this->input
        );
    }
}

// CharacterStripperTest.php

use PHPUnit\Framework\TestCase;

final class CharacterStripperTest extends TestCase {
    public function testStripRemovesSpecialChars() {
        $stripper = new CharacterStripper('hello@world#test');
        // No metaprogramming needed
        $this->assertEquals('helloworldtest', $stripper->strip());
    }

    public function testStripKeepsValidCharacters() {
        $stripper = new CharacterStripper('valid_Name-123:test');
        $this->assertEquals(
            'valid_Name-123:test', 
            $stripper->strip()
        );
    }

    public function testStripHandlesEmptyString() {
        $stripper = new CharacterStripper('');
        $this->assertEquals('', $stripper->strip());
    }

    public function testStripRemovesSpaces() {
        $stripper = new CharacterStripper('hello world test');
        $this->assertEquals('helloworldtest', $stripper->strip());
    }

    public function testStripRemovesUnicodeChars() {
        $stripper = new CharacterStripper('café™');
        $this->assertEquals('caf', $stripper->strip());
    }

    public function testStripKeepsUnderscores() {
        $stripper = new CharacterStripper('test_method_name');
        $this->assertEquals(
            'test_method_name', 
            $stripper->strip()
        );
    }

    public function testStripKeepsColons() {
        $stripper = new CharacterStripper('namespace:method');
        $this->assertEquals('namespace:method', $stripper->strip());
    }

    public function testStripKeepsHyphens() { <?php

final class McpMessageParser {
    private $raw;

    public function parse() {
        // Step 5: Replace the private method call 
        // with the new object
        $stripper = new CharacterStripper($this->raw);
        return $stripper->strip();
    }
}

// CharacterStripper.php
// Step 2: Create a new class (Method Object)
final class CharacterStripper {
    private $input;

    // Step 4: Pass all necessary data as constructor 
    // parameters
    public function __construct($input) {
        $this->input = $input;
    }

    // Step 3: Move the private method logic 
    // to the new class
    public function strip() {
        return preg_replace(
            '/[^a-zA-Z0-9_:-]/', 
            '', 
            $this->input
        );
    }
}

// CharacterStripperTest.php

use PHPUnit\Framework\TestCase;

final class CharacterStripperTest extends TestCase {
    public function testStripRemovesSpecialChars() {
        $stripper = new CharacterStripper('hello@world#test');
        // No metaprogramming needed
        $this->assertEquals('helloworldtest', $stripper->strip());
    }

    public function testStripKeepsValidCharacters() {
        $stripper = new CharacterStripper('valid_Name-123:test');
        $this->assertEquals(
            'valid_Name-123:test', 
            $stripper->strip()
        );
    }

    public function testStripHandlesEmptyString() {
        $stripper = new CharacterStripper('');
        $this->assertEquals('', $stripper->strip());
    }

    public function testStripRemovesSpaces() {
        $stripper = new CharacterStripper('hello world test');
        $this->assertEquals('helloworldtest', $stripper->strip());
    }

    public function testStripRemovesUnicodeChars() {
        $stripper = new CharacterStripper('café™');
        $this->assertEquals('caf', $stripper->strip());
    }

    public function testStripKeepsUnderscores() {
        $stripper = new CharacterStripper('test_method_name');
        $this->assertEquals(
            'test_method_name', 
            $stripper->strip()
        );
    }

    public function testStripKeepsColons() {
        $stripper = new CharacterStripper('namespace:method');
        $this->assertEquals('namespace:method', $stripper->strip());
    }

    public function testStripKeepsHyphens() { Type 📝 [X] Semi-Automatic Safety 🛡️ This refactoring is safe if you keep the same transformations and follow the Extract Method procedure. Why is the Code Better? ✨ You expose business rules instead of hiding them. You can also test sanitation and other small rules without breaking encapsulation. You remove the temptation to test private methods. test private methods All these benefits without changing the method visibility or breaking the encapsulation. How Does it Improve the Bijection? 🗺️ In the real world, complex operations often deserve their own identity. When you extract a private method into a method object, you give that operation a proper name and existence in your model. This creates a better bijection between your code and the domain. bijection You reduce coupling by making dependencies explicit through constructor parameters rather than hiding them in private methods. coupling The MAPPER technique helps you identify when a private computation represents a real-world concept that deserves its own class. MAPPER Limitations ⚠️ You shouldn't apply this refactoring to trivial private methods. Simple getters, setters, or one-line computations don't need extraction. getters setters The overhead of creating a new class isn't justified for straightforward logic. You should only extract private methods when they contain complex business logic that requires independent testing. Refactor with AI 🤖 You can ask AI to create unit tests for you. Read the context section. You need to be in control, guiding it with good practices. Suggested Prompt: 1. Identify a private method that needs testing.2. Name the real responsibility behind that logic.3. Extract the logic into a new class.4. Pass the needing objects explicitly through method arguments.5. Replace the private call with the new object. Without Proper Instructions 📵 ChatGPTClaudePerplexityCopilotYouGeminiDeepSeekMeta AIGrokQwen ChatGPT ChatGPT Claude Claude Perplexity Perplexity Copilot Copilot You You Gemini Gemini DeepSeek DeepSeek Meta AI Meta AI Grok Grok Qwen Qwen With Specific Instructions 👩‍🏫 ChatGPTClaudePerplexityCopilotYouGeminiDeepSeekMeta AIGrokQwen ChatGPT ChatGPT Claude Claude Perplexity Perplexity Copilot Copilot You You Gemini Gemini DeepSeek DeepSeek Meta AI Meta AI Grok Grok Qwen Qwen Tags 🏷️ Testing Testing Level 🔋 [X] Intermediate Related Refactorings 🔄 https://www.linkedin.com/pulse/refactoring-010-extract-method-object-maximiliano-contieri https://www.linkedin.com/pulse/refactoring-010-extract-method-object-maximiliano-contieri https://www.linkedin.com/pulse/refactoring-002-extract-method-maximiliano-contieri-mqubf https://www.linkedin.com/pulse/refactoring-002-extract-method-maximiliano-contieri-mqubf https://www.linkedin.com/pulse/refactoring-020-transform-static-functions-maximiliano-contieri-jmbif https://www.linkedin.com/pulse/refactoring-020-transform-static-functions-maximiliano-contieri-jmbif See also 📚 http://shoulditestprivatemethods.com/ http://shoulditestprivatemethods.com/ https://maximilianocontieri.com/laziness-i-meta-programming https://maximilianocontieri.com/laziness-i-meta-programming Credits 🙏 Image by Steffen Salow on Pixabay Steffen Salow Pixabay This article is part of the Refactoring Series. https://www.linkedin.com/pulse/how-improve-your-code-easy-refactorings-maximiliano-contieri https://www.linkedin.com/pulse/how-improve-your-code-easy-refactorings-maximiliano-contieri

Code Smell 313 - “Workslop” in AI-Assisted Programming

Buy My Book

Share your ideas with me!

Refactoring 037 - Testing Private Methods

About Author

Comments

TOPICS

THIS ARTICLE WAS FEATURED IN

Related Stories

10 Predictions About the Future of Finance

The Noonification: How Often Do NFTs Pass The Howey Test? (1/13/2023)

Darwin's Hybrid Intelligence to Align AI & Human Goals for Startups & VCs

The Noonification: White Man (11/26/2022)

The Noonification: The Metaverse is a Sh*tshow (11/2/2022)

100 Days of AI Day 1: From Newsletter to Podcast, Leveraging AI for Audio Transformation

10 Predictions About the Future of Finance

The Noonification: How Often Do NFTs Pass The Howey Test? (1/13/2023)

Darwin's Hybrid Intelligence to Align AI & Human Goals for Startups & VCs

The Noonification: White Man (11/26/2022)

The Noonification: The Metaverse is a Sh*tshow (11/2/2022)

100 Days of AI Day 1: From Newsletter to Podcast, Leveraging AI for Audio Transformation

Light-Mode

Classic

Newspaper

Minty

Dark-Mode

Neon Noir

Minty

HN StartUps