You execute code. Move to the other stuff, and continue with the previous code TL;DR: Don't mix your train of thought Problems Readability Bad Scoping Solutions Move the code close together Try to extract the method Refactorings Refactoring 002 - Extract Method Context Entangled code is related beyond time and space. You are reading the code, then skip to another subject and return to the first one. Sample Code Wrong def planetary_properties(semi_major_axis,
                         incoming_radiation, reflected_radiation):
    Gravitational_Constant = 1.0    
    Sun_Mass = 1.0    
    # Up to here, there's a preparation
    # for the orbital period computation
    
    albedo = reflected_radiation / incoming_radiation
    # This is unrelated to the previous computation
    
    # You resume the first computation
    orbital_period_squared = (
        (4 * math.pi**2 * semi_major_axis**3) /
        (Gravitational_Constant * Sun_Mass)
    )
    retrun orbital_period, albedo Right def planetary_properties(semi_major_axis,
                         incoming_radiation, reflected_radiation):
    Gravitational_Constant = 1.0    
    Sun_Mass = 1.0    
     orbital_period_squared = (
        (4 * math.pi**2 * semi_major_axis**3) /
        (Gravitational_Constant * Sun_Mass)
    )
    # This is related to the first computation part
    
    albedo = reflected_radiation / incoming_radiation
    # This is related to the second part
    
    # The final solution is to break the function into two
    # This is a trivial example for illustration purposes
    # Things usually get more complicated and entangled
   
    retrun orbital_period, albedo Detection Semi-Automatic [x] Some linters can infer scopes and make suggestions. Tags Readability Level Beginner [x] AI Assistants AI assistants suggest code without this mistake and improve this problem when asked. Conclusion This is a tiny tip and a short example of tidying Relations Code Smell 107 - Variables Reuse Disclaimer Code Smells are my . opinion Credits Photo by on Michael Hamments Unsplash Debugging is twice as hard as writing the code in the first place. Therefore, if you write the code as cleverly as possible, you are, by definition, not smart enough to debug it. Brian Kernighan Software Engineering Great Quotes This article is part of the CodeSmell Series: How to Find the Stinky Parts of your Code

Code Smell 239 - Big Pull Request

Code Smell 236 - What to Do With Excessively Long Code Lines

Buy My Book

Share your ideas with me!

Code Smell 238 - Dealing With Entangled Code

About Author

Comments

TOPICS

THIS ARTICLE WAS FEATURED IN

Related Stories

10 Predictions About the Future of Finance

106 Stories To Learn About Clean Code

100 Pieces of Programming Advice from the Book Clean Code by Robert Martin

110 Stories To Learn About Refactoring

3 Things Coding And Prose Writing Have In Common According To Cory House

4 Simple Habits For Engineering Teams To Beat Technical Debt

10 Predictions About the Future of Finance

106 Stories To Learn About Clean Code

100 Pieces of Programming Advice from the Book Clean Code by Robert Martin

110 Stories To Learn About Refactoring

3 Things Coding And Prose Writing Have In Common According To Cory House

4 Simple Habits For Engineering Teams To Beat Technical Debt

Light-Mode

Classic

Newspaper

Minty

Dark-Mode

Neon Noir

Minty

HN StartUps