Objects or Functions need too many arguments to work TL;DR: Don't pass more than three arguments to your functions. Problems 😔 Low maintainabilityLow ReuseCoupling Low maintainability Low Reuse Coupling Solutions 😃 Find cohesive relations among argumentsCreate a "context".Consider using a Method Object Pattern.Avoid "basic" Types: strings, arrays, integers, etc. Think on objects. Find cohesive relations among arguments Create a "context". Consider using a Method Object Pattern. Method Object Avoid "basic" Types: strings, arrays, integers, etc. Think on objects. Refactorings ⚙️ Read the articles below for refactorings. MAXIMILIANO CONTIERI - SOFTWARE DESIGNRefactoring 007 - Extract ClassBehavior is repeated across the system. But we are missing a concept MAXIMILIANO CONTIERI - SOFTWARE DESIGNRefactoring 007 - Extract ClassBehavior is repeated across the system. But we are missing a concept MAXIMILIANO CONTIERI - SOFTWARE DESIGNRefactoring 007 - Extract ClassBehavior is repeated across the system. But we are missing a concept MAXIMILIANO CONTIERI - SOFTWARE DESIGNRefactoring 007 - Extract ClassBehavior is repeated across the system. But we are missing a concept MAXIMILIANO CONTIERI - SOFTWARE DESIGN Refactoring 007 - Extract Class Behavior is repeated across the system. But we are missing a concept MAXIMILIANO CONTIERI - SOFTWARE DESIGNRefactoring 010 - Extract Method ObjectYou have a big algorithmic method. Let's break it. MAXIMILIANO CONTIERI - SOFTWARE DESIGNRefactoring 010 - Extract Method ObjectYou have a big algorithmic method. Let's break it. MAXIMILIANO CONTIERI - SOFTWARE DESIGNRefactoring 010 - Extract Method ObjectYou have a big algorithmic method. Let's break it. MAXIMILIANO CONTIERI - SOFTWARE DESIGNRefactoring 010 - Extract Method ObjectYou have a big algorithmic method. Let's break it. MAXIMILIANO CONTIERI - SOFTWARE DESIGN Refactoring 010 - Extract Method Object You have a big algorithmic method. Let's break it. HACKERNOONRefactoring 034 - Wrapping Messy Parameters Into a Single Meaningful Entity | HackerNoonWrap messy parameters into a single meaningful entity. HACKERNOONRefactoring 034 - Wrapping Messy Parameters Into a Single Meaningful Entity | HackerNoonWrap messy parameters into a single meaningful entity. HACKERNOONRefactoring 034 - Wrapping Messy Parameters Into a Single Meaningful Entity | HackerNoonWrap messy parameters into a single meaningful entity. HACKERNOONRefactoring 034 - Wrapping Messy Parameters Into a Single Meaningful Entity | HackerNoonWrap messy parameters into a single meaningful entity. HACKERNOON Refactoring 034 - Wrapping Messy Parameters Into a Single Meaningful Entity | HackerNoon Wrap messy parameters into a single meaningful entity. Context 💬 When you add arguments to make a function work, you encode knowledge in position and order. You force your callers to remember rules that belong to the domain. When you do this, you move behavior away from meaningful objects, and you replace intent with mechanics. When you add arguments to make a function work, you encode knowledge in position and order. You force your callers to remember rules that belong to the domain. When you do this, you move behavior away from meaningful objects, and you replace intent with mechanics. Sample Code 📖 Wrong 🚫 Wrong 🚫 public class Printer {   
  void print(String documentToPrint, 
           String papersize,
           String orientation, 
           boolean grayscales,
           int pagefrom,
           int pageTo,
           int copies,
           float marginLeft,
           float marginRight,
           float marginTop,
           float marginBottom         
        ) {
    }
} public class Printer {   
  void print(String documentToPrint, 
           String papersize,
           String orientation, 
           boolean grayscales,
           int pagefrom,
           int pageTo,
           int copies,
           float marginLeft,
           float marginRight,
           float marginTop,
           float marginBottom         
        ) {
    }
} Right 👉 Right 👉 final public class PaperSize { }
final public class Document { }
final public class PrintMargins { }
final public class PrintRange { }  
final public class ColorConfiguration { }
final public class PrintOrientation { }
// Class definition with methods and properties omitted for simplicity

final public class PrintSetup {
    public PrintSetup(PaperSize papersize,
           PrintOrientation orientation, 
           ColorConfiguration color,
           PrintRange range,
           int copiesCount,
           PrintMargins margins
           ) {}
}

final public class Printer {   
  void print(
         Document documentToPrint, 
         PrintSetup setup        
        ) {
    }
} final public class PaperSize { }
final public class Document { }
final public class PrintMargins { }
final public class PrintRange { }  
final public class ColorConfiguration { }
final public class PrintOrientation { }
// Class definition with methods and properties omitted for simplicity

final public class PrintSetup {
    public PrintSetup(PaperSize papersize,
           PrintOrientation orientation, 
           ColorConfiguration color,
           PrintRange range,
           int copiesCount,
           PrintMargins margins
           ) {}
}

final public class Printer {   
  void print(
         Document documentToPrint, 
         PrintSetup setup        
        ) {
    }
} Detection 🔍 Most linters warn when the arguments list is too large. You can also detect this smell when a function signature grows over time. Exceptions 🛑 Operations in real-world needing not cohesive collaborators. Some low-level functions mirror external APIs or system calls. In those cases, argument lists reflect constraints you cannot control. Tags 🏷️ Bloaters Bloaters Level 🔋 [X] Beginner Why the Bijection Is Important 🗺️ Good design keeps a clear bijection between concepts in the program and concepts in the MAPPER. bijection MAPPER When you spread a concept across many arguments, you break that mapping. You force callers to assemble meaning manually, and the model stops representing the domain. AI Generation 🤖 AI generators often create this smell. They optimize for quick success and keep adding parameters instead of creating new abstractions. AI Detection 🧲 AI generators can fix this smell when you ask for value objects or domain concepts explicitly. Try Them! 🛠 Try Them! 🛠 Remember: AI Assistants make lots of mistakes Remember: AI Assistants make lots of mistakes Suggested Prompt: Refactor this function by grouping related parameters into meaningful domain objects and reduce the argument list to one parameter Steal My Prompts (Without Proper Instructions)📵 Steal My Prompts (Without Proper Instructions) ChatGPTClaudePerplexityCopilotYouGeminiDeepSeekMeta AIGrokQwen ChatGPT ChatGPT Claude Claude Perplexity Perplexity Copilot Copilot You You Gemini Gemini DeepSeek DeepSeek Meta AI Meta AI Grok Grok Qwen Qwen Steal My Prompts (With Specific Instructions) 👩‍🏫 Steal My Prompts (With Specific Instructions) ChatGPTClaudePerplexityCopilotYouGeminiDeepSeekMeta AIGrokQwen ChatGPT ChatGPT Claude Claude Perplexity Perplexity Copilot Copilot You You Gemini Gemini DeepSeek DeepSeek Meta AI Meta AI Grok Grok Qwen Qwen Conclusion 🏁 Relate arguments and group them. Always favor real-world mappings. Find in real-world how to group the arguments in cohesive objects. If a function gets too many arguments, some of them might be related to the class construction. This is a design smell too. Related Reading https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-vii-8dk31x0 https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-vii-8dk31x0 https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-iii-t7h3zkv https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-iii-t7h3zkv https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xviii https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xviii Lead photo by Tobias Tullius on Unsplash Lead photo by Tobias Tullius on Unsplash Tobias Tullius Unsplash This article is part of the CodeSmell Series. This article is part of the CodeSmell Series. HACKERNOONHow to Find the Stinky Parts of Your Code (Part I) | HackerNoonThe code smells bad. Let’s see how to change the aromas. In this series, we will see several symptoms and situations that make us doubt the quality of our developments. We will present possible solutions. Most of these smells are just hints of something that might be wrong. They are not rigid rules. HACKERNOONHow to Find the Stinky Parts of Your Code (Part I) | HackerNoonThe code smells bad. Let’s see how to change the aromas. In this series, we will see several symptoms and situations that make us doubt the quality of our developments. We will present possible solutions. Most of these smells are just hints of something that might be wrong. They are not rigid rules. HACKERNOONHow to Find the Stinky Parts of Your Code (Part I) | HackerNoonThe code smells bad. Let’s see how to change the aromas. In this series, we will see several symptoms and situations that make us doubt the quality of our developments. We will present possible solutions. Most of these smells are just hints of something that might be wrong. They are not rigid rules. HACKERNOONHow to Find the Stinky Parts of Your Code (Part I) | HackerNoonThe code smells bad. Let’s see how to change the aromas. In this series, we will see several symptoms and situations that make us doubt the quality of our developments. We will present possible solutions. Most of these smells are just hints of something that might be wrong. They are not rigid rules. HACKERNOON How to Find the Stinky Parts of Your Code (Part I) | HackerNoon The code smells bad. Let’s see how to change the aromas. In this series, we will see several symptoms and situations that make us doubt the quality of our developments. We will present possible solutions. Most of these smells are just hints of something that might be wrong. They are not rigid rules.

Walkthroughs, tutorials, guides, and tips. This story will teach you how to do something new or how to do something better.

Code Smell 09 - What Should You Do With Dead Code?

Buy My Book

Share your ideas with me!

Code Smell 10: Functions With Too Many Arguments

About Author

Comments

TOPICS

THIS ARTICLE WAS FEATURED IN

Related Stories

10 Predictions About the Future of Finance

106 Stories To Learn About Clean Code

100 Pieces of Programming Advice from the Book Clean Code by Robert Martin

110 Stories To Learn About Refactoring

3 Things Coding And Prose Writing Have In Common According To Cory House

4 Simple Habits For Engineering Teams To Beat Technical Debt

10 Predictions About the Future of Finance

106 Stories To Learn About Clean Code

100 Pieces of Programming Advice from the Book Clean Code by Robert Martin

110 Stories To Learn About Refactoring

3 Things Coding And Prose Writing Have In Common According To Cory House

4 Simple Habits For Engineering Teams To Beat Technical Debt

Light-Mode

Classic

Newspaper

Minty

Dark-Mode

Neon Noir

Minty

HN StartUps