> 20 stories with 5 code smells each are 100 code smells, right?


---

## **Previous Code Smells**

* [Part I](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-i-xqz3evd)
* [Part II](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-ii-o96s3wl4)
* [Part III](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-iii-t7h3zkv)
* [Part IV](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-iv-7sc3w8n)
* [Part V](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-v-evj3zs9)
* [Part VI](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-vi-cmj31om)
* [Part VII](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-vii-8dk31x0)
* [Part VIII](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-viii-8mn3352)
* [Part IX](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-ix-7rr33ol)
* [Part X](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-x-i7r34uj)
* [Part XI](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xi-sit35t1)
* [Part XII](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xii)
* [Part XIII](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xiii)
* [Part XIV](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xiv)
* [Part XV](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xv)
* [Part XVI](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xvi)
* [Part XVII](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xvii)
* [Part XVIII](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xviii)
* [Part XIX](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xix)

  \

Let's continue...


---

# Code Smell 96 - My Objects

 ![](https://cdn.hackernoon.com/images/RIiBoPtpMiRsMKX3dnzl5gb1Urj1-y093ngr.jpeg)

*You don't own objects.*

> TL;DR: don't use *my* as a name prefix.

# Problems

* Lack of context
* Bijection Fault

# Solutions


1. Remove *my* prefix.
2. Change to a role suggesting name.

# Context

Several old tutorials use the word 'my' as a lazy name.
This is vague and lead to context mistakes.

# Sample Code

## Wrong

```csharp
MainWindow myWindow = Application.Current.MainWindow as MainWindow;
```

## Right

```csharp
MainWindow salesWindow = Application.Current.MainWindow as MainWindow;

/*

Since window is instanciated, we are currently working
with a specialized window playing a special role

*/
```

# Detection

- [x] Automatic

We can tell our linters and static checkers to search for this prefix and warn us.

# Tags

* Naming

# Conclusion

Avoid using *my*. Objects change according to the usage context.

# More Info

* [What exactly is a name — Part II Rehab](https://hackernoon.com/what-exactly-is-a-name-rehab-part-ii-4st3uph)

# Credits

Photo by [Michał Bożek](https://unsplash.com/@bozu) on [Unsplash](https://unsplash.com/s/photos/kid-toy)


___

> Thinking about my experience of modifying code, I see that I spend much more time reading the existing code than I do writing new code. If I want to make my code cheap, therefore, I should make it easy to read.

*Kent Beck*

[Software Engineering Great Quotes](https://hackernoon.com/400-thought-provoking-software-engineering-quotes)


___

# Code Smell 97 - Error Messages Without Empathy

 ![](https://cdn.hackernoon.com/images/RIiBoPtpMiRsMKX3dnzl5gb1Urj1-6ua3nvr.jpeg)

*We should take special care with error descriptions for the users (and ourselves).*

> TL;DR: Use meaningful descriptions and suggest corrective actions.

# Problems

* The Least Surprise Principle

# Solutions


1. Use declarative error messages
2. Show clear exit actions

# Context

Programmers are seldom UX experts.

We also underestimate the fact we can be on both sides of the counter.

# Sample Code

## Wrong

```javascript
alert("Cancel the appointment?", "Yes", "No");

// No consequences
// Options not clear
```

## Right

```javascript
alert("Cancel the appointment? \n" +
      "You will lose all the history", 
      "Cancel Appointment", 
      "Keep Editing");

// Consequences are clear
// Choice options have context
```

# Detection

- [x] Manual

We need to read all exception messages in code reviews.

# Tags

* Exceptions
* UX

# Conclusion

We need to think in our end users when raising exception or showing messages.

# Credits

Photo by [visuals](https://unsplash.com/@visuals) on [Unsplash](https://unsplash.com/s/photos/error-message)


___

> While it is a known fact that programmers never make mistakes, it is still a good idea to humor the users by checking for errors at critical points in your program.

*Robert D. Schneider*

\

___

# Code Smell 98 - Speling Mistakes

 ![](https://cdn.hackernoon.com/images/RIiBoPtpMiRsMKX3dnzl5gb1Urj1-7wc3npc.jpeg)

*Spelling and readability are very important for humans and not important for machines.*

> TL;DR: Take care of your names.

# Problems

* Readability
* Harder to search terms in code.

# Solutions


1. Spellcheck your code.
2. Use an IDE with spellchecking

# Context

Many of us don't speak English as our first language.

We need to have extra care for our texts and names.

*This article has a typo in its title as proof of context and also a clickbait*😀

# Sample Code

## Wrong

```javascript
comboFeededBySupplyer = supplyer.providers();
```

## Right

```javascript
comboFedBySupplier = supplier.providers();
```

# Detection

# Tags

* Readability
* Naming
* Code Styling

# Conclusion

Pay close attention to your names.

You will probably be the person reading the code in a few months.

# Relations

[Code Smell 48 - Code Without Standards](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-x-i7r34uj)

# More Info

[What exactly is a name — Part I The Quest](https://hackernoon.com/what-exactly-is-a-name-the-quest-part-i-fmw3udc)

[What exactly is a name — Part II Rehab](https://hackernoon.com/what-exactly-is-a-name-rehab-part-ii-4st3uph)

# Credits

Photo by [Brett Jordan](https://unsplash.com/@brett_jordan) on [Unsplash](https://unsplash.com/s/photos/alphabet)

\
> Inside every well-written large program is a well-written small program.

*C.A.R. Hoare*


___

# Code Smell 99 - First Second

 ![](https://cdn.hackernoon.com/images/RIiBoPtpMiRsMKX3dnzl5gb1Urj1-8dd3n4l.jpeg)

*How many times do we see lazy argument names?*

> TL;DR: Name your arguments according to the role and not the accidental position

# Problems

* Readability
* Intention Revealing Names

# Solutions


1. Use meaningful names

# Context

When writing methods, we usually don't stop to find decent names.

We never refactor the obvious, neither.

# Sample Code

## Wrong

```python
class Calculator:
  def subtract(self, first, second):
    return first - second

class CalculatorTest  
  def test_multiply():
    assert equals(first, second)
```

## Right

```python
class Calculator:
  def subtract(self, minuend, subtrahend):
    return minuend - subtrahend

class CalculatorTest  
  def test_multiply():
    assert equals(expectedValue, realValue)
```

# Detection

- [x] Manual

We can warn for forbidden words like 'first' and 'second' as argument names.

# Tags

* Readability

# Conclusion

Always follow rule suggesting parameter.

Name your collaborators according to the role.

# Relations

[Code Smell 65 - Variables Named after Types](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-xiii)

# More Info

[What exactly is a name — Part II Rehab](https://hackernoon.com/what-exactly-is-a-name-rehab-part-ii-4st3uph)

# Credits

Photo by [Priscilla Du Preez](https://unsplash.com/@priscilladupreez) on [Unsplash](https://unsplash.com/s/photos/two)


___

> Final source code is the real software design.

*Jack Reeves*


___

# Code Smell 100 - GoTo

 ![](https://cdn.hackernoon.com/images/RIiBoPtpMiRsMKX3dnzl5gb1Urj1-yhe3njp.jpeg)

*GOTO was considered harmful 50 years ago*

> TL;DR: Don't ever use GoTo.

# Problems

* Readability
* Hard to follow code

# Solutions


1. Replace [GOTO](https://en.wikipedia.org/wiki/Goto) with structured code
2. Use exceptions

# Context

I started programming in Basic.

GOTO was heavily abused there.

I had to learn structured programming from scratch in Rehab mode.

# Sample Code

## Wrong

```go
for x < 0 {
    if x > -1e-09 {
      goto small
    }
    z = z / x
    x = x + 1
  }
  for x < 2 {
    if x < 1e-09 {
      goto small
    }
    z = z / x
    x = x + 1
  }

  if x == 2 {
    return z
  }

  x = x - 2
  p = (((((x*_gamP[0]+_gamP[1])*x+_gamP[2])*x+_gamP[3])*x+_gamP[4])*x+_gamP[5])*x + _gamP[6]
  q = ((((((x*_gamQ[0]+_gamQ[1])*x+_gamQ[2])*x+_gamQ[3])*x+_gamQ[4])*x+_gamQ[5])*x+_gamQ[6])*x + _gamQ[7]
  return z * p / q

small:
  if x == 0 {
    return Inf(1)
  }
  return z / ((1 + Euler*x) * x)
}
```

## Right

```go
for x < 0 {
    if x > -1e-09 {
      return small(x, z)
    }
    z = z / x
    x = x + 1
  }
  for x < 2 {
    if x < 1e-09 {
      return small(x, z)
    }
    z = z / x
    x = x + 1
  }

  if x == 2 {
    return z
  }

  x = x - 2
  p = (((((x*_gamP[0]+_gamP[1])*x+_gamP[2])*x+_gamP[3])*x+_gamP[4])*x+_gamP[5])*x + _gamP[6]
  q = ((((((x*_gamQ[0]+_gamQ[1])*x+_gamQ[2])*x+_gamQ[3])*x+_gamQ[4])*x+_gamQ[5])*x+_gamQ[6])*x + _gamQ[7]
  return z * p / q

small(x, z) {
  if x == 0 {
     return Inf(1)
   }
   return z / ((1 + Euler*x) * x)
 }
}
```

# Detection

- [x] Automatic

In languages supporting *GOTO*, our linters can warn us against its usage.

# Tags

* Readability

# Conclusion

We acknowledged GOTO problems a few decades ago.

The problem is still present in [modern languages](https://en.wikipedia.org/wiki/Goto) like GoLang, PHP, Perl etc.

Most programmers luckily avoid GOTO sentence. Next goal will be to consider harmful [null usage](https://hackernoon.com/null-the-billion-dollar-mistake-8t5z32d6).

\
 ![](https://cdn.hackernoon.com/images/RIiBoPtpMiRsMKX3dnzl5gb1Urj1-hjf3n8g.png)

*Courtesy [XKCD](https://xkcd.com/292/)*

# Relations

[Code Smell 12 - Null](https://hackernoon.com/how-to-find-the-stinky-parts-of-your-code-part-iii-t7h3zkv)

# More Info

* [Goto Statement considered harmful](https://homepages.cwi.nl/\~storm/teaching/reader/Dijkstra68.pdf)
* [Wikipedia](https://en.wikipedia.org/wiki/Goto)

# Credits

Photo by [Jens Johnsson](https://unsplash.com/@jens_johnsson) on [Unsplash](https://unsplash.com/s/photos/sign)


___

> It is practically impossible to teach good programming to students that have had a prior exposure to BASIC: as potential programmers they are mentally mutilated beyond hope of regeneration.

*Edsger Dijkstra*

[Software Engineering Great Quotes](https://hackernoon.com/400-thought-provoking-software-engineering-quotes)


___

And that’s all for now, We have hit 100 milestone.

\
The next article will explain 5 more code smells!

Alphabet

Winner of Noonies 2020 for the award Hacker Noon Contributor of the Year - REFACTORING.

How to Find the Stinky Parts of Your Code [Part XX]: We have Reached 100!

Too Long; Didn't Read

Company Mentioned

@mcsee

RELATED STORIES