TL;DR: Bad function names will lead you to defects Problems Misleading Names The least surprise principle violation Solutions Avoid ambiguous or bad names Wrap with your functions Use mature languages Context Some names in immature languages break the principle. bijection When you use them, you agree on some semantics that are not the actual behavior. Consequently, you must know accidental implementations to avoid this . defect Sample Code Wrong const pets = '😺🐶😺';
const justDogs = pets.replace('😺', '🐩');

const catsArePresent = justDogs.includes('😺');
// returns true Right const pets = '😺🐶😺';

const justDogs = pets.replaceAll('😺', '🐩');
// Or
const justDogs = pets.replace(/😺/g, '');

const catsArePresent = justDogs.includes('😺');
// returns false Detection Automatic [x] You can search and forbid the usage of in your code and define if you need to change only the first occurrence replace() replaceFirst() Tags Naming Level Beginner [x] AI Generation All generators avoided this problem. AI Detection ChatGPT and Copilot use to solve the problem. Regular Expressions Gemini and Claude failed to spot the mistake. None of them use (introduced in ) replaceAll() ES2021 Conclusion Using instead of would not fully achieve the intended result of replacing all occurrences. replace() replaceAll() It would only replace the first occurrence, potentially leading to incorrect behavior if there are multiple occurrences. Relations Code Smell 38 - Abstract Names Code Smell 41 - Regular Expression Abusers More Info What exactly is a name - Part II Rehab Disclaimer Code Smells are my . opinion Credits Photo by on Jari Hytönen Unsplash We must not blame programmers for their bugs. They belong to them only until the code is merged to the repository. After that, all bugs are ours! Yegor Bugayenko Software Engineering Great Quotes This article is part of the CodeSmell Series. How to Find the Stinky Parts of your Code

Walkthroughs, tutorials, guides, and tips. This story will teach you how to do something new or how to do something better.

How To Find the Stinky Parts of Your Code: Code Smell 248 – Unreliable Copy

Code Smell 246 - Modeling Expiration Dates

Buy My Book

Share your ideas with me!

Read My Stories

Buy Me a Coffee

Too Long; Didn't Read

Make resilience your competitive advantage

Code Smell 247 - Javascript Function Naming

About Author

Comments

TOPICS

THIS ARTICLE WAS FEATURED IN

Related Stories

Untitled Story

10 Predictions About the Future of Finance

5 easy wins to refactor even the ugliest code

5 VERY common code smells and how to fix them

A Hacker Tried to Steal $566M by Exploiting a Code Smell, Here's How

Code Smell 240 - Dead Store Code

10 Predictions About the Future of Finance

5 easy wins to refactor even the ugliest code

5 VERY common code smells and how to fix them

A Hacker Tried to Steal $566M by Exploiting a Code Smell, Here's How

Code Smell 240 - Dead Store Code

Light-Mode

Classic

Newspaper

Dark-Mode

Neon Noir

Minty

HN StartUps